Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes for nag #119

Merged
merged 7 commits into from
Feb 6, 2024
Merged

Bugfixes for nag #119

merged 7 commits into from
Feb 6, 2024

Conversation

ktras
Copy link
Collaborator

@ktras ktras commented Feb 2, 2024

Various bugfixes in the code that were identified when trying to compile with nag.

types `activation_strategy_t`, `swish_t`, `relu_t`, `sigmoid_t` in
order to keep the elemental keyword.
`differentiable_activation_strategy` and
`trainable_engine%to_inference_engine` because they contain
logic that is not allowed in pure procedures.
when compiling with nagfor. These directives should be removed
when, as expected, nagfor provides support for `random_init` in
an upcoming version.
@ktras ktras requested a review from rouson February 5, 2024 20:56
@ktras ktras marked this pull request as ready for review February 5, 2024 20:56
Copy link
Contributor

@rouson rouson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rouson rouson merged commit 057ffe0 into main Feb 6, 2024
4 checks passed
@rouson rouson deleted the bugfixes-for-nag branch February 6, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants